Fix auto-sized parent not accounting for child min-width in canSkipFlex path#56167
Closed
NickGerleman wants to merge 1 commit into
Closed
Fix auto-sized parent not accounting for child min-width in canSkipFlex path#56167NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95177338. |
…ex path Summary: When a flex container with auto main-axis is measured with a with a known cross dimensions, the `canSkipFlex` optimization in `justifyMainAxis` uses `computedFlexBasis` directly. This doesn't account for the `min` & `max` width constraints, causing the parent to undersize. I have added a `.html` test page here to mirror the C++ test I added to confirm that flexbox does respect the min-width constraint. [minwidth-test.html](https://github.com/user-attachments/files/25695677/minwidth-test.html) Changelog: [Internal] X-link: react/yoga#1905 Reviewed By: sammy-SC, adityasharat Differential Revision: D95177338 Pulled By: NickGerleman
NickGerleman
force-pushed
the
export-D95177338
branch
from
791afee to
5745f26
Compare
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95177338. |
meta-codesync Bot
pushed a commit
to react/yoga
that referenced
this pull request
Mar 24, 2026
…ex path (#1905) Summary: X-link: react/react-native#56167 When a flex container with auto main-axis is measured with a with a known cross dimensions, the `canSkipFlex` optimization in `justifyMainAxis` uses `computedFlexBasis` directly. This doesn't account for the `min` & `max` width constraints, causing the parent to undersize. I have added a `.html` test page here to mirror the C++ test I added to confirm that flexbox does respect the min-width constraint. [minwidth-test.html](https://github.com/user-attachments/files/25695677/minwidth-test.html) Changelog: [Internal] Pull Request resolved: #1905 Reviewed By: sammy-SC, adityasharat Differential Revision: D95177338 Pulled By: NickGerleman fbshipit-source-id: bca0b2089ec01a747e86423c6f00160223e6b764
Collaborator
|
This pull request was successfully merged by @jhargreaves-spec in b6387d9 When will my fix make it into a release? | How to file a pick request? |
|
@NickGerleman merged this pull request in b6387d9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a flex container with auto main-axis is measured with a with a known cross dimensions, the
canSkipFlexoptimization injustifyMainAxisusescomputedFlexBasisdirectly. This doesn't account for themin&maxwidth constraints, causing the parent to undersize.I have added a
.htmltest page here to mirror the C++ test I added to confirm that flexbox does respect the min-width constraint. minwidth-test.htmlChangelog: [Internal]
X-link: react/yoga#1905
Reviewed By: sammy-SC, adityasharat
Differential Revision: D95177338
Pulled By: NickGerleman